Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] num2words: add support to translate some currencies in italian language #434

Merged
merged 2 commits into from
Aug 16, 2022
Merged

[ADD] num2words: add support to translate some currencies in italian language #434

merged 2 commits into from
Aug 16, 2022

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Jan 16, 2022 •
edited
Loading

Changes proposed in this pull request:

  • Adding support for italian translation of some currencies (to_currency)
  • Tests for italian language currencies

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

lang='it'                                                                                     
var1 = '49.95'                                                                                                                                 
var2 = '1.01'                                                                              
b = num2words(var1, lang=lang, to='currency', currency='USD')
print(b)                                                               
d = num2words(var2, lang=lang, to='currency', currency='EUR')
print(d)

@primes2h primes2h changed the title [ADD[ num2words: add support to translate some currencies in italian language [ADD] num2words: add support to translate some currencies in italian language Jan 16, 2022
@primes2h primes2h force-pushed the add-to_currency_support branch 2 times, most recently from 77adc53 to a4ad103 Compare January 16, 2022 13:32
@primes2h primes2h mentioned this pull request Jun 21, 2022
Merged
@mrodriguezg1991
Copy link
Contributor

@primes2h Hello, can you update this PR with the master branch in order to run the test and review it
Thanks

@primes2h
Copy link
Contributor Author

@primes2h Hello, can you update this PR with the master branch in order to run the test and review it Thanks

Done, thank you.

@mrodriguezg1991
Copy link
Contributor

mrodriguezg1991 commented Aug 15, 2022 •
edited
Loading

@primes2h Can yo fix the following to pass flake8 validation in python3.10

 ./tests/test_it.py:54:1: E302 expected 2 blank lines, found 1
 ./num2words/lang_IT.py:203:1: E302 expected 2 blank lines, found 1

Thanks

@primes2h
Copy link
Contributor Author

@primes2h Can yo fix the following to pass flake8 validation in python3.10

 ./tests/test_it.py:54:1: E302 expected 2 blank lines, found 1
 ./num2words/lang_IT.py:203:1: E302 expected 2 blank lines, found 1

Thanks

Done!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2862776794

  • 39 of 40 (97.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 96.513%
Changes Missing Coverage Covered Lines Changed/Added Lines %
num2words/lang_IT.py 27 28 96.43%
Totals Coverage Status
Change from base Build 2840410724: 0.003%
Covered Lines: 7117
Relevant Lines: 7296
💛 - Coveralls

@primes2h
Copy link
Contributor Author

@mrodriguezg1991

All ✔️ now.

@mrodriguezg1991 mrodriguezg1991 merged commit d8c199b into savoirfairelinux:master Aug 16, 2022
@primes2h primes2h deleted the add-to_currency_support branch August 17, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodriguezg1991 mrodriguezg1991 mrodriguezg1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@primes2h @mrodriguezg1991 @coveralls